PD-6046 PD-6045 PD-6045 PD-6046 PD-6044 PD-6042 PD-6043 PD-5850 add 2FA recovery phone number - #7655
Merged
Merged
Conversation
RedisClient hardcoded .ssl(true). A plaintext Redis does not reject a TLS
handshake, it simply never answers, so every connect blocked until the
socket read timed out: 20 s for the two 10 s-timeout clients and 40 s for
the 20 s one. Four clients are built per startup because web.xml builds the
Spring context twice, which is 120 s of a 148 s deploy.
Add a ssl constructor argument defaulting to true, wired through all four
bean definitions as ${...ssl.enabled:true}. Production keeps TLS with no
configuration change. This mirrors SessionCacheConfig, which already reads
...cache.session.redis.ssl.enabled with the same shape and the same default.
Turning TLS off then exposed a second defect: a blank password was still
passed to the Jedis config, so the client sent AUTH "" and an unauthenticated
Redis answered
ERR AUTH <password> called without any password configured for the default user
which meant the pool never came up and the cache stayed silently disabled --
set() returning false and get() returning null for every caller. Treat a
blank or null password as "no authentication". A configured password is
unaffected.
Measured on an isolated Tomcat against the real WAR, with the context still
built twice and the original timeouts: startup 148.5 s -> 44.9 s, and three
Redis clients now connect successfully where none did before.
(cherry picked from commit 57c6a37)
amontenegro
requested changes
Sep 18, 2026
| } | ||
|
|
||
| @Override | ||
| @Transactional |
Member
There was a problem hiding this comment.
Remove the @transactional as the transaction will be handled by the transactionTemplate
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") | ||
| public ProfileRecoveryPhoneEntity findByOrcid(String orcid) { |
Member
There was a problem hiding this comment.
With the hibernate/hikari upgrade, we now need to specify the read only transaction as well, so, plaese add this annotation:
@transactional(value = "transactionManagerReadOnly", readOnly = true)
amontenegro
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.